Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GreyNoise analyzer #236

Merged
merged 3 commits into from
Jun 4, 2018
Merged

GreyNoise analyzer #236

merged 3 commits into from
Jun 4, 2018

Conversation

danielbrowne
Copy link

Creating a new analyzer for GreyNoise.
https://github.com/GreyNoise-Intelligence/api.greynoise.io

Referencing #231

@danielbrowne danielbrowne mentioned this pull request Apr 21, 2018
@3c7 3c7 added category:enhancement Issue is related to an existing feature to improve scope:analyzer Issue is analyzer related status:needs-review labels May 29, 2018
@3c7 3c7 added this to the 1.10.0 milestone May 29, 2018
@3c7 3c7 changed the base branch from develop to release/1.10.0 June 4, 2018 08:25
@3c7
Copy link
Contributor

3c7 commented Jun 4, 2018

Hey @danielbrowne, thanks for your contribution! Do you have - by chance - already created a template for TheHive?

@3c7 3c7 added status:needs-template Analyzer still needs a template for TheHive and removed status:needs-review labels Jun 4, 2018
@danielbrowne
Copy link
Author

Hi @3c7, I have not done that. I am not that familiar with the product, is that a requirement for this work to be useful?

@3c7
Copy link
Contributor

3c7 commented Jun 4, 2018

As the main use case for analyzers is the query out of TheHive, it would be cool if you could provide either a template for it or an example of the data returned by the analyzer so we can create a template. Examples for templates can be found in https://github.com/TheHive-Project/Cortex-Analyzers/tree/master/thehive-templates.

If no template is provided, the users will just see a JSON object which is not that UX friendly. ;)

@3c7
Copy link
Contributor

3c7 commented Jun 4, 2018

Ah, just saw that the returned data is quite nice described in the the link you provided. So, do you want to try to create a template or should we do it?

@danielbrowne
Copy link
Author

@3c7 I am not sure that I will be able to get to it soon due to being flooded by other commitments, if it is easy for someone else to create it, that would be great :)

@3c7 3c7 merged commit 9d70474 into TheHive-Project:release/1.10.0 Jun 4, 2018
@3c7
Copy link
Contributor

3c7 commented Jun 4, 2018

Added a template. :)

@danielbrowne
Copy link
Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:enhancement Issue is related to an existing feature to improve scope:analyzer Issue is analyzer related status:needs-template Analyzer still needs a template for TheHive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants