Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/evaluation: Using optionally Docker to prevent compatibility problems with Analyzers #171

Closed
wants to merge 25 commits into from

Conversation

3c7
Copy link
Contributor

@3c7 3c7 commented Jan 17, 2018

This is WIP and needs discussion.

@3c7 3c7 added category:enhancement Issue is related to an existing feature to improve scope:question labels Jan 17, 2018
@3c7 3c7 mentioned this pull request Jan 25, 2018
@BrevilleBro
Copy link

Good work @3c7 , I think this is the way forward for Cortex analyzers if we want to maintain compatibility.

@3c7 3c7 changed the base branch from master to develop February 11, 2018 13:12
@ghost
Copy link

ghost commented Feb 18, 2018

Would this allow cortex analyzers to start running on different Docker images (Windows)? For example I could see a cortex analyzer that check Office 365 block lists which are only available over PowerShell at the moment.

@3c7 3c7 mentioned this pull request May 15, 2018
@geekscrapy
Copy link

geekscrapy commented May 15, 2018

@ryanmcvicar I guess if you used docker swarm that'd be fairly easy to distribute analyzers across platforms

@3c7
Copy link
Contributor Author

3c7 commented May 24, 2018

  • Fix cortex-base-python3 image
  • Fix unterminated quoted string bug
  • Check for possibilities to reduce image sizes

@3c7 3c7 requested a review from jeromeleonard May 24, 2018 17:41
@3c7 3c7 modified the milestones: 1.10.0, 1.11.0 Jun 4, 2018
@jeromeleonard jeromeleonard modified the milestones: 1.11.0, 1.12.0 Jun 26, 2018
@3c7
Copy link
Contributor Author

3c7 commented Jun 26, 2018

Basically finished, just postponed to the next cortex (bugfix) release.

@3c7 3c7 mentioned this pull request Jun 28, 2018
@3c7
Copy link
Contributor Author

3c7 commented Aug 18, 2018

Continued in #334 as I cannot change the branch.

@3c7 3c7 closed this Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:enhancement Issue is related to an existing feature to improve scope:question
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants