-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tor blutmagie #139
Tor blutmagie #139
Conversation
Thanks for the fast response. Caching works great.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the requested change, everything works perfect. Also, it could be considered to include #!/usr/bin/env python3
instead of #!/usr/bin/env python
in tor_blutmagie_analyzer.py, because of the python2/python3 encoding issues that will pop up, if people run that analyzer using python2.
{{n.name}} | ||
</div> | ||
<div class="panel-body"> | ||
<dl class="dl-horizontal"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div class="panel-body"> | ||
<dl class="dl-horizontal"> | ||
<dd>Address</dd> | ||
<dt>{{n.hostname | fang}} ({{n.ip_address | fang}})</dt> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, it has to be n.ip
.
</dl> | ||
<span> | ||
<i class="fa fa-search"></i> | ||
<a ng-href="http://torstatus.blutmagie.de/cgi-bin/whois.pl?ip={{n.ip_address}}" target="_blank">WHOIS</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be n.ip
, also.
Here are the fixes. I am so sorry for those basic errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the contribution.
As for PR #138, this PR aims to offer a solution to issue #45 with an analyzer extracting data from torstatus.blutmagie.de to check if an artifact is linked to a TOR node. The artifact can be an IP address, a FQDN or a domain.
I documented both of the classes but if you need a more advance documentation, please tell me. Also, I hope i coped with your coding standards. If not tell me so I can fix it.
As for #138, there is a caching system in place.