-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified & enhanced docs wrt paths #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change HardLinkShell description
clarify: files are difficult, not impossible, to manipulate
fix readability make similar sections consistent elaborate workarounds discourage users from setting up xserver clarify long paths not being completely un-manipulatable clarify implication that mc is not a linux program link to hardlinkshell explain explorer not supporting long paths even with new group policy further resources: tools and further reading
minor text changes, present tense, readability, specify path length limits apply to windows only
Worse at spelling than thefrenchghosty
Outstanding issue, if cygwin doesn't support long paths (what's the point of using it, then), then simply add note in readme in the future to specify only WSL's support. |
- modify wsl/cygwin heading levels to be consistent with thefrenchghosty's existing files in docs folder - Clarify long-path'ed files as not being corrupt or problematic - tell the user they can organize files as they wish, but caveat emptor - exercise restraint by not adding section telling user to consider using linux
Still has some typos |
TheFrenchGhosty
approved these changes
Jul 17, 2021
Sorry that it took me so long to get to it. Thanks a lot for this really detailed documentation enhancement! This will definitely help windows users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original without modifying your docs: https://pad.snopyta.org/ykmEOXasS5GiaEF1f9eymw
Pull request because:
Issue 1 - replace references to long paths in cygwin/wsl subsections
Aside from the WSL-specific instructions, most of the stuff relating to long paths (background, workarounds, video player apps) are not specific to WSL, and equally apply to the Cygwin-Git-Bash section. I've stripped all mentions of long paths from the new WSL & existing Cygwin-Git-Bash sections. This keeps both parts purely install-related. A common section redirecting to docs/LongPaths is added to them both, with a cliffhanger (videos won't be playable) to entice users to actually read it
Issue 2 - Modify README.md
Issue 3 - Create docs/LongPaths.md