Enabled intra refresh #155
Conversation
WalkthroughThe changes in this pull request involve two main updates. First, the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FFMpegDecoder
participant Renderer
User->>FFMpegDecoder: Request Decoder
FFMpegDecoder->>Renderer: Set Capabilities (Pull + Intra Refresh)
Renderer-->>FFMpegDecoder: Acknowledge Capabilities
FFMpegDecoder-->>User: Provide Decoder
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
Streaming/FFmpegDecoder.cpp (2)
298-298: Consider adding error resilience configurationSince intra-refresh is being enabled for error resilience, consider also configuring related FFmpeg decoder parameters like error concealment and recovery options.
Add the following configuration after the decoder context initialization:
decoder_ctx->get_format = ffGetFormat; +// Configure error resilience options +decoder_ctx->err_recognition = AV_EF_CAREFUL; +decoder_ctx->flags |= AV_CODEC_FLAG_OUTPUT_CORRUPT; // Output frames even with errors
298-298: Document the implications of CAPABILITY_INTRA_REFRESHThe addition of this capability flag has implications for both the client and server behavior in terms of video streaming quality and error recovery.
Add a comment explaining the purpose:
- decoder_callbacks_sdl.capabilities = CAPABILITY_PULL_RENDERER | CAPABILITY_INTRA_REFRESH; + // Enable pull-based rendering and intra-refresh support for better error resilience + // CAPABILITY_INTRA_REFRESH signals the server to periodically send intra-refresh frames + // instead of full IDR frames for more efficient error recovery + decoder_callbacks_sdl.capabilities = CAPABILITY_PULL_RENDERER | CAPABILITY_INTRA_REFRESH;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
Streaming/FFmpegDecoder.cpp(1 hunks)third_party/moonlight-common-c(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- third_party/moonlight-common-c
🔇 Additional comments (1)
Streaming/FFmpegDecoder.cpp (1)
298-298: Verify intra-refresh support in FFmpeg decoder implementation
While adding the CAPABILITY_INTRA_REFRESH flag signals to Moonlight that intra-refresh is supported, we should verify that the FFmpeg decoder implementation properly handles intra-refresh frames when they are received.
Let's verify the integration:
|
Ask for Intra-refresh when setting up the client.
This PR completes the PR of:
moonlight-common-c: moonlight-stream/moonlight-common-c#97
Sunshine: LizardByte/Sunshine#3415
Summary by CodeRabbit
New Features
Chores
moonlight-common-csubproject.