Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup reportgenerator invocations on non-windows machines #90

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

baronfel
Copy link
Collaborator

@baronfel baronfel commented Jun 21, 2018

Proposed Changes

I had to make some changes to the process-spawning code for reportgenerator on a project I had in order to get it to run.

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

The two main fixes are

  1. mono prefix when on non-windows, and
  2. need to wrap the prefix argument in quotes so that shells don't try to expand them.

@TheAngryByrd TheAngryByrd merged commit 82ed19a into TheAngryByrd:master Jun 22, 2018
TheAngryByrd pushed a commit that referenced this pull request Jun 22, 2018
* MINOR: fixup report generator invocations on non-windows machines (#90)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants