Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified build.fsx to fix Issue #82 #83

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

ScottHutchinson
Copy link
Contributor

Proposed Changes

Modified the getTargetFrameworksFromProjectFile function to call the new getTargetFrameworks function to prevent a null reference exception when there is no TargetFrameworks element in the .fsproj file.

See #82

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x ] Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Modified the getTargetFrameworksFromProjectFile  function to call the new getTargetFrameworks function to prevent a null reference exception when there is no TargetFrameworks element in the .fsproj file.

See TheAngryByrd#82
@TheAngryByrd
Copy link
Owner

Thanks!

@TheAngryByrd TheAngryByrd merged commit 7370989 into TheAngryByrd:master Apr 9, 2018
TheAngryByrd pushed a commit that referenced this pull request Apr 9, 2018
* BUGFIX: Handle TargetFramework as well as TargetFrameworks in proj files (#83)
* DOCUMENTATION: Update Tree output (#80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants