Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sourcelink Tests and many cleanups #69

Merged
merged 9 commits into from
Mar 16, 2018
Merged

Conversation

TheAngryByrd
Copy link
Owner

Proposed Changes

This adds sourcelink test to the build process to ensure sourcelink is working correctly. I've also added a bunch of small tweaks I tend to do to projects after using miniscaffold and have incorporated them back.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd merged commit f2e7964 into master Mar 16, 2018
TheAngryByrd pushed a commit that referenced this pull request Mar 16, 2018
* FEATURE: SourceLink testing (#69)
* FEATURE: Integration testing at the FAKE level for different perumutations (#70)
* MINOR: Lots of small refactorings/additions (#69)
@TheAngryByrd TheAngryByrd deleted the many-cleanups branch December 24, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant