Use Expecto's new --log-name parameter #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log messages will now make it obvious which framework (core, net461...) was running the tests when that log message was produced.
|
Works on MacOS, I'll publish a beta |
TheAngryByrd
pushed a commit
that referenced
this pull request
Mar 6, 2018
* FEATURE: Use expecto's --log-name to specify targetframework when running tests. Bumps Expecto to 6.0.0 and dotnet-mono to 0.5.1. (#60)
TheAngryByrd
pushed a commit
that referenced
this pull request
Mar 7, 2018
* FEATURE: Use expecto's --log-name to specify targetframework when running tests. Bumps Expecto to 6.0.0 and dotnet-mono to 0.5.1. (#60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #59 by bumping the required Expecto version to 6.0.0 (in order to use the
--log-nameparameter) and dotnet-mono to 0.5.1 (so that its syntax will match thedotnet runsyntax, with a bare--parameter separating dotnet-mono params from params intended for the program being run).Note that I have only tested this on one Linux machine so far, so it might be good to try this PR on at least a couple more machines before merging it and pushing a new version of the template.