Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unwanted cosnole.clear #54

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented Feb 25, 2018

As discussed in #53 (comment) we found that some interaction between mono, fake, dotnetcore, and expecto has an odd side effect when using Console.Readline as the stopping mechanism

Closes #53

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

As discussed in #53 (comment) we found that some interaction between mono, fake, dotnetcore, and expecto has an odd side effect when using Console.Readline as the stopping mechanism
@TheAngryByrd TheAngryByrd force-pushed the 53-unwanted-console-clear branch from e595319 to 8088af1 Compare February 25, 2018 14:30
@TheAngryByrd TheAngryByrd merged commit 4d4759d into master Feb 25, 2018
TheAngryByrd pushed a commit that referenced this pull request Feb 25, 2018
* BUGFIX: Fixed unwanted cosnole.clear (#54)
* BUGFIX: paket bootstrapper TLS issues (#55)
TheAngryByrd pushed a commit that referenced this pull request Feb 25, 2018
* BUGFIX: Fixed unwanted cosnole.clear (#54)
* BUGFIX: paket bootstrapper TLS issues (#55)
@TheAngryByrd TheAngryByrd deleted the 53-unwanted-console-clear branch December 24, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted Console.Clear() happens when I run WatchTests, but only on net461 framework target
1 participant