Update Fantomas and format using dotnet tool. #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
commented
Oct 8, 2021
nojaf
commented
Oct 8, 2021
nojaf
commented
Oct 8, 2021
|
Thank you! On mobile right now but I get a review in soon |
TheAngryByrd
requested changes
Oct 8, 2021
There was a problem hiding this comment.
Looks great overall! Left some feedback.
Additionally could you make these changes to the LIbrary version as well?
|
Hey @TheAngryByrd, thanks for the positive feedback! |
TheAngryByrd
added a commit
that referenced
this pull request
Oct 11, 2021
## [0.29.1-beta001] - 2021-10-11 ### Changed - [Update Fantomas and format using dotnet tool](#247)
TheAngryByrd
added a commit
that referenced
this pull request
Oct 11, 2021
## [0.29.1] - 2021-10-11 ### Changed - [Update Fantomas and format using dotnet tool](#247)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Hi @TheAngryByrd, sorry for now opening an issue first.
I'd like to bump the Fantomas version here, the current version 3.2 is quite old. And nowadays it is recommended to format outside of the FAKE process using the local .NET tool.
Types of changes
What types of changes does your code introduce to MiniScaffold?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
This PR isn't totally finished as I'm not sure if you are onboard with all the changes. I'll ask some specific questions in the code.
Let me know what you think.