Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move off fake-cli #246

Merged
merged 7 commits into from
Sep 13, 2021
Merged

Move off fake-cli #246

merged 7 commits into from
Sep 13, 2021

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented Sep 9, 2021

Proposed Changes

This moves the build scripts away from using fake-cli and using a dotnet project to run it. fake-cli hasn't been updated in quite a long time and isn't using the latest version of FSharp.Compiler.Services so tooling like Ionide work with it anymore.

There aren't major changes to the build script other than configuring it to run in just a dotnet process. The big differences are:

These should help anyone looking to migrate their code to use a dotnet project.

Summary

  • This moves build.fsx to a .fsproj under ./build/ which is largely similar.
  • Updates FAKE packages off the alpha version to the release
  • Updates paket tool off beta to release version

Deals with #231 a bit

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd marked this pull request as draft September 9, 2021 14:38
@TheAngryByrd TheAngryByrd force-pushed the move-away-from-fake-runner branch from 8aa9b09 to 7b4424a Compare September 9, 2021 14:40
@TheAngryByrd TheAngryByrd marked this pull request as ready for review September 10, 2021 14:43
@TheAngryByrd TheAngryByrd merged commit 8bebb47 into master Sep 13, 2021
@TheAngryByrd TheAngryByrd deleted the move-away-from-fake-runner branch September 13, 2021 17:25
TheAngryByrd added a commit that referenced this pull request Sep 29, 2021
## [0.29.0-beta001] - 2021-09-29

### Changed
- [Move off fake-cli to build.fsproj](#246)
TheAngryByrd added a commit that referenced this pull request Sep 29, 2021
## [0.29.0] - 2021-09-29

### Changed
- [Move off fake-cli to build.fsproj](#246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant