Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses TargetFramework since we're only targetting net5.0 #241

Merged
merged 1 commit into from
May 28, 2021

Conversation

TheAngryByrd
Copy link
Owner

This helps when running tests in expectos runner vs the dotnet test runner

Proposed Changes

Closes #239

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

n/a

This helps when running tests in expectos runner vs the dotnet test runner
@TheAngryByrd TheAngryByrd enabled auto-merge (squash) May 28, 2021 13:28
@TheAngryByrd TheAngryByrd merged commit ab0d907 into master May 28, 2021
@TheAngryByrd TheAngryByrd deleted the 239-use-singular-targetframework-in-fsproj branch May 28, 2021 13:45
TheAngryByrd added a commit that referenced this pull request May 28, 2021
## [0.27.0-beta001] - 2021-05-28

### Added
- Adds README to nuget package which will be displayed on nuget.org from [@TheAngryByrd](https://github.com/TheAngryByrd)) - #242

### Changed
- Using TargetFramework in projects because we're only targeting net5.0 from [@TheAngryByrd](https://github.com/TheAngryByrd)) - #241
TheAngryByrd added a commit that referenced this pull request May 28, 2021
## [0.27.0-beta002] - 2021-05-28

### Changed
- FSharp-Analyzers updated to 0.9.0, global.json version update to 5.0.300, MSBuild.StructuredLogger pinned to 2.1.500 from[@TheAngryByrd](https://github.com/TheAngryByrd)) -
- #244
- Octokit pinned to 0.48 from [@enovales](https://github.com/enovales) - #243

- Using TargetFramework in projects because we're only targeting net5.0 from [@TheAngryByrd](https://github.com/TheAngryByrd)) - #241

### Added
- Adds README to nuget package which will be displayed on nuget.org from [@TheAngryByrd](https://github.com/TheAngryByrd)) - #242
TheAngryByrd added a commit that referenced this pull request May 28, 2021
## [0.27.0] - 2021-05-28

### Changed
- FSharp-Analyzers updated to 0.9.0, global.json version update to 5.0.300, MSBuild.StructuredLogger pinned to 2.1.500 from[@TheAngryByrd](https://github.com/TheAngryByrd) - #244
- Octokit pinned to 0.48 from [@enovales](https://github.com/enovales) - #243
- Using TargetFramework in projects because we're only targeting net5.0 from [@TheAngryByrd](https://github.com/TheAngryByrd)) - #241

### Added
- Adds README to nuget package which will be displayed on nuget.org from [@TheAngryByrd](https://github.com/TheAngryByrd)) - #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executing test project with dotnet run -p fails unless --framework option is passed to dotnet run
1 participant