Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage will only include what we have the source code for #218

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Code coverage will only include what we have the source code for #218

merged 1 commit into from
Jul 25, 2020

Conversation

simon-reynolds
Copy link
Contributor

@simon-reynolds simon-reynolds commented Jul 25, 2020

Proposed Changes

Addresses #210
Adds an extra parameter for AltCover to only calculate code coverage for code that we have the source files for

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Already made these changes to EFCore.FSharp build file where it is no longer also trying to provide code coverage for all of EF Core

@TheAngryByrd
Copy link
Owner

Awesome thank you!

@TheAngryByrd TheAngryByrd merged commit 42f3bf2 into TheAngryByrd:master Jul 25, 2020
TheAngryByrd added a commit that referenced this pull request Jul 25, 2020
## [0.25.0-beta001] - 2020-07-25

### Fixed
- Code coverage will only include what we have the source code for from [@simontaite](https://github.com/simontaite) - #218

### Removed
- Travis and AppVeyor CI scripts in favor of GitHub Actions from [@TheAngryByrd](https://github.com/TheAngryByrd) - #217
TheAngryByrd added a commit that referenced this pull request Jul 25, 2020
## [0.25.0] - 2020-07-25

### Fixed
- Code coverage will only include what we have the source code for from [@simontaite](https://github.com/simontaite) - #218

### Removed
- Travis and AppVeyor CI scripts in favor of GitHub Actions from [@TheAngryByrd](https://github.com/TheAngryByrd) - #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants