-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions for MiniScaffold itself #145
Conversation
If I just opt into the actions beta and these files exist, it should just work? |
@TheAngryByrd That's the plan anyway. ;-) I know there have been some issues around getting Actions to build on forks. Let me know when you've signed up, we'll see what happens. |
the page doesn’t want to load. I’ve submitted an issue to GitHub so we’ll see where that ends up. Thanks for the work 😊 |
This link doesn't work? https://github.com/features/actions/signup/?account=TheAngryByrd @TheAngryByrd |
@TheAngryByrd Ah I just now saw that it actually built. |
So my script blocker was blocking the page :), LGTM now |
Proposed Changes
This builds MiniScaffold itself with GitHub Actions on Ubuntu, MacOS and Windows.
It's the first step of #143.
Test Run
The next step is to have the templates do the same.
GitHub actions is in beta and is scheduled to be released Nov 13. One can apply for the beta here. There is no waiting list any longer according to Nat Friedman.
There is a workaround in the workflow right now because of a bug in setup-dotnet. PR here. Once the bug is fixed, the
DOTNET_ROOT
line below can be removed in two places.Types of changes
Checklist
Further comments
This PR includes the changes in #144, so if those changes aren't acceptable I'll have some rebasing to do. 😅