Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions for MiniScaffold itself #145

Merged
merged 4 commits into from
Sep 19, 2019

Conversation

rojepp
Copy link
Contributor

@rojepp rojepp commented Sep 19, 2019

Proposed Changes

This builds MiniScaffold itself with GitHub Actions on Ubuntu, MacOS and Windows.
It's the first step of #143.
Test Run
The next step is to have the templates do the same.
GitHub actions is in beta and is scheduled to be released Nov 13. One can apply for the beta here. There is no waiting list any longer according to Nat Friedman.

There is a workaround in the workflow right now because of a bug in setup-dotnet. PR here. Once the bug is fixed, the DOTNET_ROOT line below can be removed in two places.

      env:
        # Work around https://github.com/actions/setup-dotnet/issues/29
        DOTNET_ROOT: ${{ runner.tool_cache }}/dncs/${{ matrix.dotnet }}/x64

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

This PR includes the changes in #144, so if those changes aren't acceptable I'll have some rebasing to do. 😅

@rojepp rojepp changed the title Gh actions GitHub Actions for MiniScaffold itself Sep 19, 2019
@TheAngryByrd
Copy link
Owner

If I just opt into the actions beta and these files exist, it should just work?

@TheAngryByrd TheAngryByrd merged commit 31ef208 into TheAngryByrd:master Sep 19, 2019
@rojepp
Copy link
Contributor Author

rojepp commented Sep 19, 2019

@TheAngryByrd That's the plan anyway. ;-) I know there have been some issues around getting Actions to build on forks. Let me know when you've signed up, we'll see what happens.

@rojepp
Copy link
Contributor Author

rojepp commented Sep 19, 2019

@rojepp rojepp deleted the gh-actions branch September 19, 2019 14:35
@TheAngryByrd
Copy link
Owner

the page doesn’t want to load. I’ve submitted an issue to GitHub so we’ll see where that ends up. Thanks for the work 😊

@rojepp
Copy link
Contributor Author

rojepp commented Sep 19, 2019

@rojepp
Copy link
Contributor Author

rojepp commented Sep 19, 2019

@TheAngryByrd Ah I just now saw that it actually built.

@TheAngryByrd
Copy link
Owner

So my script blocker was blocking the page :), LGTM now

TheAngryByrd pushed a commit that referenced this pull request Sep 20, 2019
* FEATURE: Github Actions (#145) (#146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants