Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code coverage environment variable #139

Merged
merged 3 commits into from
Jun 4, 2019
Merged

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented Jun 1, 2019

Proposed Changes

Closes #138

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

AltCover tend to exhibit slowness when recording visitations, this allows for the user to skip using altcover and generating a report
@TheAngryByrd
Copy link
Owner Author

@rmunn how does this look to you?

@TheAngryByrd TheAngryByrd changed the title 138 coverage switch code coverage environment variable Jun 2, 2019
@TheAngryByrd TheAngryByrd force-pushed the 138-coverage-switch branch from fd76061 to e5ea5bd Compare June 3, 2019 15:23
@TheAngryByrd TheAngryByrd force-pushed the 138-coverage-switch branch from e5ea5bd to 57d2f1f Compare June 3, 2019 15:23
@rmunn
Copy link
Contributor

rmunn commented Jun 4, 2019

I was thinking a command-line parameter, but an environment variable actually means you can "set it and forget it" in one shell session with export DISABLE_COVERAGE=1 without affecting coverage for your other shell tabs, or add it to your .bashrc if you really want to turn it off by default. And since you're already using environment variables for other things, this makes a lot of sense.

LGTM.

@TheAngryByrd TheAngryByrd merged commit 78050a2 into master Jun 4, 2019
TheAngryByrd pushed a commit that referenced this pull request Jun 4, 2019
* FEATURE: Adds environment variable `DISABLE_COVERAGE` to disable code coverage (#139)
TheAngryByrd pushed a commit that referenced this pull request Jun 4, 2019
* FEATURE: Adds environment variable `DISABLE_COVERAGE` to disable code coverage (#139)
@TheAngryByrd TheAngryByrd deleted the 138-coverage-switch branch December 24, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making code coverage optional since it slows things down a lot
2 participants