Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do dotnet pack via sln #123

Merged
merged 1 commit into from
May 2, 2019
Merged

do dotnet pack via sln #123

merged 1 commit into from
May 2, 2019

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented Mar 15, 2019

Proposed Changes

This make it so dotnet pack runs on the sln file. It adds IsPackable with true to Directory.Build.props in src and false in tests.

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@TheAngryByrd TheAngryByrd mentioned this pull request Apr 9, 2019
6 tasks
@TheAngryByrd TheAngryByrd merged commit d601f3e into master May 2, 2019
TheAngryByrd pushed a commit that referenced this pull request May 2, 2019
* FEATURE: Run tests via solution file to speed up build if multiple test projects (#124)
* FEATURE: Run pack via solution via to speed up build if multiple library projects (#123)
* FEATURE: Add recommended vscode plugins (#128)
@TheAngryByrd TheAngryByrd deleted the packable-sln branch December 24, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant