Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Directory.build.props for metadata #118

Merged
merged 2 commits into from
Feb 10, 2019
Merged

Use Directory.build.props for metadata #118

merged 2 commits into from
Feb 10, 2019

Conversation

TheAngryByrd
Copy link
Owner

Proposed Changes

This uses Directory.build.props to store the metadata for a project. Useful in scenarios where this will output multiple nuget package libraries from the same repository.

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Jimmy Byrd added 2 commits January 16, 2019 17:09
This will make it easier to have multiple libraries in the same repo and keep the metadata consistent
Copy link
Collaborator

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@baronfel baronfel merged commit c5dc442 into master Feb 10, 2019
TheAngryByrd pushed a commit that referenced this pull request Feb 18, 2019
* MINOR: Use Directory.build.props for nuget metadata (#118)
* FEATURE: Update CI dotnet versions and TargetFrameworks to latest (#119)
TheAngryByrd pushed a commit that referenced this pull request Feb 19, 2019
* MINOR: Use Directory.build.props for nuget metadata (#118)
* FEATURE: Update CI dotnet versions and TargetFrameworks to latest (#119)
@TheAngryByrd TheAngryByrd deleted the build-props branch December 24, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants