-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
62 docs generation fsharp formatting #110
Conversation
Thanks to @ominestre for a lot of the conversion help! |
TODO:
|
@baronfel I have hot reloading for things in |
I pushed up some fixes for comments, we had the rendering of them inside an if-expression that was a bit too broad. To clarify the structure of the |
a16ec02
to
fdf1557
Compare
7b0085e
to
4082e3b
Compare
Things left to do:
@baronfel @jdodds I think we need to just build a Trie for the nav structure. Then building that into a sub nav dropdown structure with bootstrap. @andrewpucci I think we're at the point where I'll need your help whenever you get a chance to save me from my design skills. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. There's definitely some cleaning up we can do with the styles, but we can do that in a new issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionality-wise it's great. I have a couple suggestions/questions around the structure of the templates themselves.
Class "xmldoc" | ||
] [ | ||
for sec in comment.Sections do | ||
if byCategory |> Seq.exists (fun m -> m.GroupKey = sec.Key) |> not then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly, I've seen this xmldoc section repeated as well. seems like a good place for a component/function.
* FEATURE: Documentation generation (#110)
Proposed Changes
Adding Documentation Generation
Closes #62
Types of changes
What types of changes does your code introduce to MiniScaffold?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments