Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mean, median, mode #83

Merged
merged 7 commits into from
Oct 16, 2022
Merged

mean, median, mode #83

merged 7 commits into from
Oct 16, 2022

Conversation

talesricr
Copy link
Contributor

Created mean, median, mode files with simple algorithms for it
Also changed Directory.md

darwinz
darwinz reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@darwinz darwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@talesricr thank you for contributing! This looks great, except it's missing unit tests. Please add tests here

talesricr
talesricr commented Oct 13, 2022
View reviewed changes
Copy link
Contributor Author

@talesricr talesricr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Unit test
Also make some litte changes in tests file just to padronize

darwinz
darwinz approved these changes Oct 16, 2022
View reviewed changes
Copy link
Contributor

@darwinz darwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the contribution! And thanks for adding those tests!

@darwinz darwinz merged commit 6a67bf2 into TheAlgorithms:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darwinz darwinz darwinz approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talesricr @darwinz