Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Extra Tests for Splay Tree Operations #171

Merged

Conversation

Ramy-Badr-Ahmed
Copy link
Member

@Ramy-Badr-Ahmed Ramy-Badr-Ahmed commented Oct 10, 2024

Addendum to my #168,

  • Added tests to verify the correct tree size after deleting single and multiple nodes.

    • testDeleteExistingKey(): Checks the tree size after single node deletion.
    • testDeleteMultipleKeys(): Checks the tree size after the multiple random node deletion.
    • testLargeTree(): Checks tree operations, search, delete, abd insert on large tree structure.
  • Added abstract declaration for setRoot() in the SplayTreeRotations.php as it references its child class implementation as static::setRoot() in both rotateLeft() and rotateRight()

  • Minor typo fixes


Reference

Data Structures and Algorithms in C++, 2nd Edition

Ramy-Badr-Ahmed and others added 30 commits August 24, 2024 21:17
Copy link
Member Author

@Ramy-Badr-Ahmed Ramy-Badr-Ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @darwinz,
Looking forward to your review 🙂

PHP Composer

Code style

directory_md

@Ramy-Badr-Ahmed Ramy-Badr-Ahmed force-pushed the features/splay-tree-extra branch from c101c92 to e2d9d80 Compare October 11, 2024 18:13
@Ramy-Badr-Ahmed Ramy-Badr-Ahmed changed the title Added extra tests for Splay Tree deletion operations Added Extra Tests for Splay Tree Operations Oct 12, 2024
Copy link
Contributor

@darwinz darwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the improvements!

@darwinz darwinz merged commit cb2bbf9 into TheAlgorithms:master Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants