Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointer check #970

Merged
merged 21 commits into from
Jun 19, 2018
Merged

Pointer check #970

merged 21 commits into from
Jun 19, 2018

Conversation

wsdwsd0829
Copy link
Contributor

Check Null that called from touchMoved.

wsdwsd0829 added 20 commits July 16, 2017 16:59
@wsdwsd0829
fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449
929d118
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
dd24d8f
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
b8eaffa
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
2918ea0
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
9c42266
@wsdwsd0829
Fix to make rangeMode update in right time
329f35f
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
5f8b7ec
@wsdwsd0829
merge master from upstream
d87bb11
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
269c2ab
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
24c1ce8
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
233169e
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
b19f90d
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
b50cec4
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
b75a5f3
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
64b46e0
@wsdwsd0829
remove uncessary assert
5fabc1e
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
3d5b84b
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
098b978
@wsdwsd0829
Merge branch 'master' of github.com:TextureGroup/Texture
77eefd6
@wsdwsd0829
fix pointer check
14a73a5
maicki
maicki approved these changes Jun 16, 2018
View reviewed changes
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the fix @wsdwsd0829!

Adlai-Holler
Adlai-Holler reviewed Jun 18, 2018
View reviewed changes
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the diff! I think we want the pointer check to ONLY apply to setting the out-value. We should still return nil if there is no text range at that point.

@wsdwsd0829
Copy link
Contributor Author

Yeah, thanks. that match previous behavior better.

@ghost
Copy link

ghost commented Jun 19, 2018

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

@nguyenhuy nguyenhuy merged commit f4f1454 into TextureGroup:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adlai-Holler Adlai-Holler Adlai-Holler left review comments

@maicki maicki maicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wsdwsd0829 @maicki @Adlai-Holler @nguyenhuy