Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't Use Associated Objects for Drawing Priority #trivial #239

Merged
merged 1 commit into from
May 5, 2017
Merged

Don't Use Associated Objects for Drawing Priority #trivial #239

merged 1 commit into from
May 5, 2017

Conversation

Adlai-Holler
Copy link
Member

No idea why this was implemented this way in the first place, but let's get rid of it.

@Adlai-Holler Adlai-Holler requested review from maicki and nguyenhuy May 5, 2017 03:00
maicki
maicki approved these changes May 5, 2017
View reviewed changes
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird that is is an associated object. Usually this pattern is used for big object to decrease the memory size of the initial object but for an NSInteger?

@Adlai-Holler Adlai-Holler merged commit 80357b1 into master May 5, 2017
@garrettmoon
Copy link
Member

Super weird!

@Adlai-Holler Adlai-Holler deleted the AHDontAssociateDrawingPriority branch May 5, 2017 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Adlai-Holler @garrettmoon @maicki