Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NS_SWIFT_UI_ACTOR to methods always called on main #2121

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Add NS_SWIFT_UI_ACTOR to methods always called on main #2121

merged 2 commits into from
Jan 29, 2025

Conversation

rcancro
Copy link
Contributor

@rcancro rcancro commented Jan 29, 2025 •
edited
Loading

Initial attempt to mark all methods that are guaranteed to run on main as NS_SWIFT_UI_ACTOR.

andyfinnell
andyfinnell approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@andyfinnell andyfinnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. Have we tested these changes in a codebase with a Swift 6 (Xcode 16) compiler?

Source/ASCollectionNode.h Show resolved Hide resolved
Source/ASDisplayNode.h Show resolved Hide resolved
Source/ASTableNode.h Outdated Show resolved Hide resolved
Source/ASTableNode.h Outdated Show resolved Hide resolved
@rcancro rcancro merged commit 83c6ff8 into TextureGroup:master Jan 29, 2025
11 checks passed
@rcancro rcancro deleted the actor branch January 29, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfinnell andyfinnell andyfinnell approved these changes

@raycsh017 raycsh017 Awaiting requested review from raycsh017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcancro @andyfinnell