Cleanup for cgFloatForYogaFloat #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maicki
commented
Jul 5, 2019
maicki
commented
- Return CGFloat
- Proper check for YGUndefined
- Add YGUndefined default return value
- Return CGFloat - Proper check for YGUndefined - Add YGUndefined default return value
rahul-malik
reviewed
Jul 22, 2019
| width = cgFloatForYogaFloat(width); | ||
| height = cgFloatForYogaFloat(height); | ||
| width = cgFloatForYogaFloat(width, CGFLOAT_MAX); | ||
| height = cgFloatForYogaFloat(height, CGFLOAT_MAX); |
There was a problem hiding this comment.
Is there a case where the undefined default is something besides CGFLOAT_MAX?
There was a problem hiding this comment.
good point. I think it's cleaner to stick to CGFLOAT_MAX as the default value (and thus no need for the extra undefinedDefault param) until we have cases in which CGFLOAT_MAX is not desired.
There was a problem hiding this comment.
There will be a case where CGFLOAT_MAX is not desired ...
nguyenhuy
previously approved these changes
Jul 28, 2019
nguyenhuy
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.