Markdown tables #2977
Merged
Markdown tables #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2977 +/- ##
==========================================
- Coverage 98.31% 94.70% -3.61%
==========================================
Files 74 74
Lines 7949 8013 +64
==========================================
- Hits 7815 7589 -226
- Misses 134 424 +290
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
willmcgugan
requested changes
May 31, 2023
| @@ -4,6 +4,9 @@ | |||
|
|
|||
| from markdown_it import MarkdownIt | |||
| from markdown_it.token import Token | |||
| from typing_extensions import get_args | |||
|
|
|||
| from rich.table import Table | |||
There was a problem hiding this comment.
Can we use relative imports to match the rest of the code base.
willmcgugan
approved these changes
May 31, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Adds support for Markdown tables.
Includes support for column alignment.