Added debug configuration for vscode #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmenard
approved these changes
Nov 30, 2018
src/lib/cli/run.command.ts
Outdated
| @@ -14,10 +14,11 @@ export class RunCommand implements CliCommand { | |||
| include: ['**/*.spec.ts'] | |||
| }; | |||
|
|
|||
| constructor(private logger: Logger, private _configFile: string = 'testy.json') { } | |||
| constructor(private logger: Logger, private _configFile: string = 'testy.json', private _tsConfigFile = 'tsconfig.json') { } | |||
There was a problem hiding this comment.
Any reason in particular for prefixing these two with underscore? (and not logger)
There was a problem hiding this comment.
They are prefixed with underscores because they have public getters, whereas the logger is purely private. The public getters are currently only used for testing purposes though, which is not ideal IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.