Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade to xunit v3 #728

Merged
merged 11 commits into from
Jan 25, 2025
Merged

refactor: upgrade to xunit v3 #728

merged 11 commits into from
Jan 25, 2025

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Jan 24, 2025

Upgrade testing projects to xunit v3 and remove the .NET Stryker mutation badge, because Stryker.NET doesn't handle xUnit v3 properly.

@vbreuss vbreuss added refactor A change or improvement without functional impact breaking change The changes require a new major version labels Jan 24, 2025
@vbreuss vbreuss self-assigned this Jan 24, 2025
Copy link

github-actions bot commented Jan 24, 2025

👽 Mutation Results

Mutation testing badge

Testably.Abstractions.Testing

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions.AccessControl

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions.Compression

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Copy link

github-actions bot commented Jan 24, 2025

Test Results

    36 files  +    5      36 suites  +5   15m 46s ⏱️ +28s
41 240 tests +2 013  39 039 ✅ +1 984  2 201 💤 + 30  0 ❌  - 1 
81 217 runs  +4 846  72 799 ✅ +4 570  8 418 💤 +277  0 ❌  - 1 

Results for commit 6b08953. ± Comparison against base commit 580969d.

This pull request removes 31618 and adds 33631 tests. Note that renamed tests count towards both.
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path1b5c7cc1-ed7d-4b4a-bd0b-ad61ced01725")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2d3333ce-c68b-4810-b490-12a712a0014d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path317e7230-16cf-4d64-a47e-d5c65d83b1ce")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path4f26c22a-75d3-4176-9d62-be557edd4362")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathb200ab72-b834-4146-aff8-00b0d7733198")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathf0194b40-05a9-4ad6-9d28-92ffb3d6e35d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path072b2512-1b7c-42a2-91ce-c11fed20f1f7")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path18aa3133-cc82-4eb9-a42f-9790edc00c26")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path39b74019-f6dd-4681-98df-4dc3150846f7")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path706f53c8-af58-4fcc-b116-927e589bd6fc")
…
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path25e3baa1-3972-44fe-954a-0587dfabe005")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2bd45e44-2d57-4d6f-b43c-ba33fafd6e4f")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path71072d8f-d7fa-4e4c-ae23-e4b5551c39c4")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path71780472-e4cf-41a9-9c1b-61af41d56c16")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path84198453-65dc-4cf4-8a14-96afbaee360a")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathce355f81-ff81-4764-b326-1f6aefea2624")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathdc7a7fa5-3593-456f-9d05-2383cc719a70")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2d738c40-134a-4880-aa77-d5f1c0fffbd5")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path42ce828c-be30-451b-8ffb-055237525bdf")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path678308ea-e80e-4088-9626-451058a0f32c")
…
This pull request removes 1548 skipped tests and adds 1586 skipped tests. Note that renamed tests count towards both.
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2d3333ce-c68b-4810-b490-12a712a0014d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path317e7230-16cf-4d64-a47e-d5c65d83b1ce")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathb200ab72-b834-4146-aff8-00b0d7733198")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathf0194b40-05a9-4ad6-9d28-92ffb3d6e35d")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path072b2512-1b7c-42a2-91ce-c11fed20f1f7")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path18aa3133-cc82-4eb9-a42f-9790edc00c26")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path8a45e888-c1bb-4fa6-9274-82ebd68c9f2e")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe26c89f1-7929-4a61-818f-c9e43b9772d3")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path235e4090-a079-4125-9354-60f2a3bc9843")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path3fe6bf50-0231-4df6-bd10-a9bec9f03c8b")
…
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path25e3baa1-3972-44fe-954a-0587dfabe005")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2bd45e44-2d57-4d6f-b43c-ba33fafd6e4f")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path71780472-e4cf-41a9-9c1b-61af41d56c16")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+MockFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathdc7a7fa5-3593-456f-9d05-2383cc719a70")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path2d738c40-134a-4880-aa77-d5f1c0fffbd5")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path42ce828c-be30-451b-8ffb-055237525bdf")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "path9a4e3918-0c57-4f6d-8d65-593d86dfdb72")
Testably.Abstractions.AccessControl.Tests.DirectoryInfoAclExtensionsTests+RealFileSystemTests ‑ SetAccessControl_ShouldNotUpdateTimes(path: "pathe96ca49c-e438-4a30-bd31-7c3367a43171")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path5c7d1d36-7877-4f4f-a968-ea7913f85908")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path9054a1c4-6534-4922-981b-f7c0deca4b45")
…

♻️ This comment has been updated with latest results.

@vbreuss vbreuss enabled auto-merge (squash) January 24, 2025 13:44
@vbreuss vbreuss disabled auto-merge January 24, 2025 13:44
@vbreuss vbreuss enabled auto-merge (squash) January 24, 2025 13:45
@vbreuss vbreuss force-pushed the topic/update-to-xunit3 branch from 19315bd to bc61af3 Compare January 24, 2025 16:11
@vbreuss vbreuss disabled auto-merge January 25, 2025 05:41
vbreuss and others added 3 commits January 25, 2025 07:02
# Conflicts:
#	.github/workflows/build.yml
#	Feature.Flags.props
#	Tests/Testably.Abstractions.Compression.Tests/ZipArchive/Tests.cs
#	Tests/Testably.Abstractions.Compression.Tests/ZipArchiveEntry/Tests.cs
#	Tests/Testably.Abstractions.Testing.Tests/Statistics/FileSystem/DirectoryStatisticsTests.cs
#	Tests/Testably.Abstractions.Testing.Tests/Statistics/FileSystem/FileStatisticsTests.cs
#	Tests/Testably.Abstractions.Testing.Tests/Statistics/FileSystem/FileSystemWatcherStatisticsTests.cs
#	Tests/Testably.Abstractions.Testing.Tests/Statistics/FileSystem/PathStatisticsTests.cs
#	Tests/Testably.Abstractions.Tests/FileSystem/Directory/Tests.cs
@vbreuss vbreuss enabled auto-merge (squash) January 25, 2025 07:08
@vbreuss vbreuss changed the title refactor: disable explicit .NET7 and upgrade to xunit v3 refactor: upgrade to xunit v3 Jan 25, 2025
@vbreuss vbreuss removed the breaking change The changes require a new major version label Jan 25, 2025
@vbreuss vbreuss merged commit 6656062 into main Jan 25, 2025
15 checks passed
@vbreuss vbreuss deleted the topic/update-to-xunit3 branch January 25, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A change or improvement without functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant