Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mutation comment during update #705

Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix: mutation comment during update #705

merged 3 commits into from
Jan 10, 2025

Conversation

vbreuss
Copy link
Member

@vbreuss vbreuss commented Jan 10, 2025

When the mutation comment is updated, it adds an incorrect string:
image

@vbreuss vbreuss added the bug Something isn't working label Jan 10, 2025
@vbreuss vbreuss self-assigned this Jan 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

Test Results

   46 files  ±0     46 suites  ±0   1m 59s ⏱️ +10s
3 190 tests  - 3  3 150 ✅  - 3   40 💤 ±0  0 ❌ ±0 
9 026 runs  ±0  8 821 ✅ ±0  205 💤 ±0  0 ❌ ±0 

Results for commit 26e7c37. ± Comparison against base commit 8959969.

This pull request removes 2380 and adds 2377 tests. Note that renamed tests count towards both. 
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [102, 17, 244])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [104, 167, 56])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [121, 192, 83])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [136, 249, 60])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [140, 191, 79])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [224, 7, 80])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [243, 52, 188])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [254, 69, 220])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [45, 244, 184])
Testably.Abstractions.Testing.Tests.FileSystem.ChangeDescriptionTests ‑ ToString_ShouldIncludeChangeType(changeType: Created, fileSystemType: Directory, notifyFilters: FileName, path: "path0e2fa53f-3c52-44d5-a287-26a4f8c3d422")
…

Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [131, 187, 253])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [134, 5, 149])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [15, 42, 115])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [245, 69, 70])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [249, 91, 212])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [33, 120, 26])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [41, 132, 45])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [69, 46, 192])
Testably.Abstractions.Compression.Tests.Internal.ZipUtilitiesTests ‑ ExtractRelativeToDirectory_FileWithTrailingSlash_ShouldThrowIOException(bytes: [89, 106, 100])
Testably.Abstractions.Testing.Tests.FileSystem.ChangeDescriptionTests ‑ ToString_ShouldIncludeChangeType(changeType: Created, fileSystemType: Directory, notifyFilters: FileName, path: "path48518e4b-2d3a-4c5e-98ab-76458956cbad")
…
This pull request removes 39 skipped tests and adds 39 skipped tests. Note that renamed tests count towards both. 
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path2c8d1c26-da9e-4a49-9446-01a3e6e88bec")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path3fc9fd0c-864c-423c-8e6c-c19db02410e8")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathd2358a76-14da-42ca-9d01-4335a2d56004")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathf254f271-b5cd-4bff-92d4-55ee2b29e7e2")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "path08eadff9-aeb1-4a09-ac41-9d8deee3e1d3", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "path9223c1fa-8e88-4054-a9f5-dfd1db24ca39", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path10a01ec4a-19ea-4df5-8e3f-451b72258395", path2: "path221140e32-0112-4756-8d3f-a561461c1a03")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path11ef327c3-d105-43c5-942b-79aad760b18a", path2: "path2182aa8a2-d4c5-4979-8b78-9b56926730aa")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path15b3e554e-1e41-46f5-b247-120a0b1a6081", path2: "path21a4db184-d375-4c8c-8a7e-f644e038a7d3")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path15d9b57bc-06fd-4f2e-8c24-df8504721b61", path2: "path214adda96-828d-4c30-bc7d-ae84b9648f42")
…

Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path0a07f875-9a99-4c9e-97cb-71c9f12dca28")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path39b81dfc-9b18-4c07-8716-ff41a3c323fc")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "path8382649e-847a-4c84-af0f-469ff7f624db")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ GetUnixFileMode_SafeFileHandle_ShouldThrowPlatformNotSupportedExceptionOnWindows(path: "pathc6a4fc47-ec26-44ca-ab3e-56dd3c46e8e3")
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "path2890a82a-c44d-4ec3-8b31-e7e8f3e37bb8", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileMockTests ‑ SetUnixFileMode_SafeFileHandle_ShouldUpdateValue(path: "patha61e8621-c86d-4769-88c7-a166520f9c17", mode: None)
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path12e665d74-9228-4443-a22a-5aa63b1ca237", path2: "path27057f519-0767-4038-ac39-5940befded38")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path150daaa19-3339-40b1-be2b-9aec6df30bd6", path2: "path2a945db8e-016c-439d-9d18-ec36cbb26ed3")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path175348538-b522-4fe0-8fc1-83263c1e991a", path2: "path2821f4fd5-351f-4b2f-859f-2dc16b8e6f7c")
Testably.Abstractions.Testing.Tests.FileSystem.FileSystemWatcherMockTests ‑ InternalBufferSize_ShouldResetQueue(path1: "path1940ec09f-4585-4ddf-ba5a-6f88829b886e", path2: "path299f44352-aa59-4f19-b806-8ec629cfbe44")
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

👽 Mutation Results

Mutation testing badge

Testably.Abstractions.Testing

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions.AccessControl

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions.Compression

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

Testably.Abstractions

Details
File Score Killed Survived Timeout No Coverage Ignored Compile Errors Total Detected Total Undetected Total Mutants

The final mutation score is NaN%

Coverage Thresholds: high:80 low:60 break:0

@vbreuss vbreuss marked this pull request as ready for review January 10, 2025 09:32
@vbreuss vbreuss enabled auto-merge (squash) January 10, 2025 09:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vbreuss vbreuss merged commit 2f6e114 into main Jan 10, 2025
14 checks passed
@vbreuss vbreuss deleted the topic/fix-mutation-comment branch January 10, 2025 10:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2025

This is addressed in release v4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vbreuss vbreuss

Labels
bug Something isn't working state: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vbreuss