fix: sonar issue xUnit1040 (#445)

Fix [xUnit1040](https://xunit.net/xunit.analyzers/rules/xUnit1040) The type argument to TheoryData is nullable, while the type of the corresponding test method parameter is not. *This was introduced in #443*
Testably · Jan 7, 2024 · fd4d65b · fd4d65b
1 parent d31fe46
commit fd4d65b
Show file tree

Hide file tree

Showing 10 changed files with 29 additions and 29 deletions.
diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/ExceptionTests.cs
@@ -116,9 +116,9 @@ public void
 
 	#region Helpers
 
-	public static TheoryData<Expression<Action<IDirectoryInfo>>, string?, bool> GetDirectoryInfoCallbacks(string? path)
+	public static TheoryData<Expression<Action<IDirectoryInfo>>, string, bool> GetDirectoryInfoCallbacks(string? path)
 	{
-		TheoryData<Expression<Action<IDirectoryInfo>>, string?, bool> theoryData = new();
+		TheoryData<Expression<Action<IDirectoryInfo>>, string, bool> theoryData = new();
 		foreach (var item in GetDirectoryInfoCallbackTestParameters(path!)
 			.Where(item => item.TestType.HasFlag(path.ToTestType())))
 		{
@@ -130,7 +130,7 @@ public void
 		return theoryData;
 	}
 
-	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
+	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
 			Expression<Action<IDirectoryInfo>> Callback)>
 		GetDirectoryInfoCallbackTestParameters(string value)
 	{

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfoFactory/ExceptionTests.cs
@@ -94,9 +94,9 @@ public void
 
 	#region Helpers
 
-	public static TheoryData<Expression<Action<IDirectoryInfoFactory>>, string?, bool> GetDirectoryInfoFactoryCallbacks(string? path)
+	public static TheoryData<Expression<Action<IDirectoryInfoFactory>>, string, bool> GetDirectoryInfoFactoryCallbacks(string? path)
 	{
-		TheoryData<Expression<Action<IDirectoryInfoFactory>>, string?, bool> theoryData = new();
+		TheoryData<Expression<Action<IDirectoryInfoFactory>>, string, bool> theoryData = new();
 		foreach (var item in GetDirectoryInfoFactoryCallbackTestParameters(path!)
 			.Where(item => item.TestType.HasFlag(path.ToTestType())))
 		{
@@ -108,7 +108,7 @@ public void
 		return theoryData;
 	}
 
-	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
+	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
 			Expression<Action<IDirectoryInfoFactory>> Callback)>
 		GetDirectoryInfoFactoryCallbackTestParameters(string value)
 	{

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/DriveInfoFactory/ExceptionTests.cs
@@ -63,9 +63,9 @@ public void Operations_WhenValueIsNull_ShouldThrowArgumentNullException(
 
 	#region Helpers
 
-	public static TheoryData<Expression<Action<IDriveInfoFactory>>, string?, bool> GetDriveInfoFactoryCallbacks(string? path)
+	public static TheoryData<Expression<Action<IDriveInfoFactory>>, string, bool> GetDriveInfoFactoryCallbacks(string? path)
 	{
-		TheoryData<Expression<Action<IDriveInfoFactory>>, string?, bool> theoryData = new();
+		TheoryData<Expression<Action<IDriveInfoFactory>>, string, bool> theoryData = new();
 		foreach (var item in GetDriveInfoFactoryCallbackTestParameters(path!)
 			.Where(item => item.TestType.HasFlag(path.ToTestType())))
 		{

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/File/ExceptionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/File/ExceptionTests.cs
@@ -106,9 +106,9 @@ public void
 
 	#region Helpers
 
-	public static TheoryData<Expression<Action<IFile>>, string?, bool> GetFileCallbacks(string? path)
+	public static TheoryData<Expression<Action<IFile>>, string, bool> GetFileCallbacks(string? path)
 	{
-		TheoryData<Expression<Action<IFile>>, string?, bool> theoryData = new();
+		TheoryData<Expression<Action<IFile>>, string, bool> theoryData = new();
 		foreach (var item in GetFileCallbackTestParameters(path!)
 			.Where(item => item.TestType.HasFlag(path.ToTestType())))
 		{
@@ -120,7 +120,7 @@ public void
 		return theoryData;
 	}
 
-	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
+	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
 			Expression<Action<IFile>> Callback)>
 		GetFileCallbackTestParameters(string value)
 	{

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ExceptionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfo/ExceptionTests.cs
@@ -84,9 +84,9 @@ public void
 
 	#region Helpers
 
-	public static TheoryData<Expression<Action<IFileInfo>>, string?, bool> GetFileInfoCallbacks(string? path)
+	public static TheoryData<Expression<Action<IFileInfo>>, string, bool> GetFileInfoCallbacks(string? path)
 	{
-		TheoryData<Expression<Action<IFileInfo>>, string?, bool> theoryData = new();
+		TheoryData<Expression<Action<IFileInfo>>, string, bool> theoryData = new();
 		foreach (var item in GetFileInfoCallbackTestParameters(path!)
 			.Where(item => item.TestType.HasFlag(path.ToTestType())))
 		{
@@ -98,7 +98,7 @@ public void
 		return theoryData;
 	}
 
-	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
+	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
 			Expression<Action<IFileInfo>> Callback)>
 		GetFileInfoCallbackTestParameters(string value)
 	{

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileInfoFactory/ExceptionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileInfoFactory/ExceptionTests.cs
@@ -94,9 +94,9 @@ public void
 
 	#region Helpers
 
-	public static TheoryData<Expression<Action<IFileInfoFactory>>, string?, bool> GetFileInfoFactoryCallbacks(string? path)
+	public static TheoryData<Expression<Action<IFileInfoFactory>>, string, bool> GetFileInfoFactoryCallbacks(string? path)
 	{
-		TheoryData<Expression<Action<IFileInfoFactory>>, string?, bool> theoryData = new();
+		TheoryData<Expression<Action<IFileInfoFactory>>, string, bool> theoryData = new();
 		foreach (var item in GetFileInfoFactoryCallbackTestParameters(path!)
 			.Where(item => item.TestType.HasFlag(path.ToTestType())))
 		{
@@ -108,7 +108,7 @@ public void
 		return theoryData;
 	}
 
-	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
+	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
 			Expression<Action<IFileInfoFactory>> Callback)>
 		GetFileInfoFactoryCallbackTestParameters(string value)
 	{

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileStreamFactory/ExceptionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileStreamFactory/ExceptionTests.cs
@@ -107,9 +107,9 @@ public void
 
 	#region Helpers
 
-	public static TheoryData<Expression<Action<IFileStreamFactory>>, string?, bool> GetFileStreamFactoryCallbacks(string? path)
+	public static TheoryData<Expression<Action<IFileStreamFactory>>, string, bool> GetFileStreamFactoryCallbacks(string? path)
 	{
-		TheoryData<Expression<Action<IFileStreamFactory>>, string?, bool> theoryData = new();
+		TheoryData<Expression<Action<IFileStreamFactory>>, string, bool> theoryData = new();
 		foreach (var item in GetFileStreamFactoryCallbackTestParameters(path!)
 			.Where(item => item.TestType.HasFlag(path.ToTestType())))
 		{
@@ -121,7 +121,7 @@ public void
 		return theoryData;
 	}
 
-	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
+	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
 			Expression<Action<IFileStreamFactory>> Callback)>
 		GetFileStreamFactoryCallbackTestParameters(string value)
 	{

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileSystemInfo/ExceptionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileSystemInfo/ExceptionTests.cs
@@ -47,9 +47,9 @@ public void Operations_WhenValueIsNull_ShouldThrowArgumentNullException(
 
 	#region Helpers
 
-	public static TheoryData<Expression<Action<IFileSystemInfo>>, string?, bool> GetFileSystemInfoCallbacks(string? path)
+	public static TheoryData<Expression<Action<IFileSystemInfo>>, string, bool> GetFileSystemInfoCallbacks(string? path)
 	{
-		TheoryData<Expression<Action<IFileSystemInfo>>, string?, bool> theoryData = new();
+		TheoryData<Expression<Action<IFileSystemInfo>>, string, bool> theoryData = new();
 		foreach (var item in GetFileSystemInfoCallbackTestParameters(path!)
 			.Where(item => item.TestType.HasFlag(path.ToTestType())))
 		{
@@ -61,7 +61,7 @@ public void Operations_WhenValueIsNull_ShouldThrowArgumentNullException(
 		return theoryData;
 	}
 
-	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
+	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
 			Expression<Action<IFileSystemInfo>> Callback)>
 		GetFileSystemInfoCallbackTestParameters(string value)
 	{

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/FileSystemWatcherFactory/ExceptionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/FileSystemWatcherFactory/ExceptionTests.cs
@@ -97,9 +97,9 @@ public void
 
 	#region Helpers
 
-	public static TheoryData<Expression<Action<IFileSystemWatcherFactory>>, string?, bool> GetFileSystemWatcherFactoryCallbacks(string? path)
+	public static TheoryData<Expression<Action<IFileSystemWatcherFactory>>, string, bool> GetFileSystemWatcherFactoryCallbacks(string? path)
 	{
-		TheoryData<Expression<Action<IFileSystemWatcherFactory>>, string?, bool> theoryData = new();
+		TheoryData<Expression<Action<IFileSystemWatcherFactory>>, string, bool> theoryData = new();
 		foreach (var item in GetFileSystemWatcherFactoryCallbackTestParameters(path!)
 			.Where(item => item.TestType.HasFlag(path.ToTestType())))
 		{
@@ -111,7 +111,7 @@ public void
 		return theoryData;
 	}
 
-	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
+	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
 			Expression<Action<IFileSystemWatcherFactory>> Callback)>
 		GetFileSystemWatcherFactoryCallbackTestParameters(string value)
 	{

diff --git a/Tests/Testably.Abstractions.Tests/FileSystem/Path/ExceptionTests.cs b/Tests/Testably.Abstractions.Tests/FileSystem/Path/ExceptionTests.cs
@@ -66,9 +66,9 @@ public void Operations_WhenValueIsNull_ShouldThrowArgumentNullException(
 
 	#region Helpers
 
-	public static TheoryData<Expression<Action<IPath>>, string?, bool> GetPathCallbacks(string? path)
+	public static TheoryData<Expression<Action<IPath>>, string, bool> GetPathCallbacks(string? path)
 	{
-		TheoryData<Expression<Action<IPath>>, string?, bool> theoryData = new();
+		TheoryData<Expression<Action<IPath>>, string, bool> theoryData = new();
 		foreach (var item in GetPathCallbackTestParameters(path!)
 			.Where(item => item.TestType.HasFlag(path.ToTestType())))
 		{
@@ -80,7 +80,7 @@ public void Operations_WhenValueIsNull_ShouldThrowArgumentNullException(
 		return theoryData;
 	}
 
-	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string? ParamName,
+	private static IEnumerable<(ExceptionTestHelper.TestTypes TestType, string ParamName,
 			Expression<Action<IPath>> Callback)>
 		GetPathCallbackTestParameters(string value)
 	{