Optionally format numbers in the Feature Info panel according to user locale #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddCommas' tag used in template. Still need to remove from legends, and add flag to allow it.
|
Actually I have a better idea, based on #1302 - set the formatting directly in tableStyle, where it can be used by both the Feature Info Panel and the Legend (and any future functionality). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a template tag which formats the number according to the user's locale, if available.
Reverses the default so that, without this tag, numbers are shown without commas. This was chosen because frequently numbers are IDs or phone numbers.
Eg.
{{#localeFormat}}1234567.8{{/localeFormat}}=>1,234,567.8.Addresses #1172. It does not quite fix it, as to be consistent, the same behaviour should apply to the legend. This will be the subject of an upcoming PR.