Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release newui #1427

Closed
51 of 62 tasks
RacingTadpole opened this issue Apr 6, 2016 · 3 comments
Closed
51 of 62 tasks

Release newui #1427

RacingTadpole opened this issue Apr 6, 2016 · 3 comments

Comments

@RacingTadpole
Copy link
Contributor

RacingTadpole commented Apr 6, 2016

Here are the tasks remaining to complete the newui branch:

Packages

  • Decide to use webpack and Babel.
  • Implement webpack and Babel.
  • Now that key changes have been merged into html-to-react, use an official release.

Feature Info Panel

  • Must update if the data has a time dimension.
  • Show message if >100 features.
  • Sanitises HTML.
  • Escapes HTML only as necessary (eg. currently shows & as & in bird info).
  • Formats numbers.
  • Has working tests.
  • Shows html directly. Note:
    • Applying <style> tags in that html is hard - I propose we ignore them.
    • With the retirement of google maps engine, do we need this html to have a white background any more? I propose we show the html on our standard background.
  • Show raw data button.
  • Download CSV button.
  • Does not generate html-to-react warnings about <br>, <img> or <table><span>.
  • No feature info is shown for WFS layers, eg. on #test's data.gov.au link, "ABC Local Stations".
  • Support czml properties.
  • Support properties._terria_columnAliases from Provide csv properties with both old and new names to feature info panel #1501.

Charts

  • MVP (as per Charts with the new UI #1278).
  • Run it past Phil - requested fixes for: similar line colors; tooltip padding; making preview y-axis standout if it hits the chart line.
  • Prevent all chart data from being cached for 2 weeks.
  • If raw data is passed in to <chart>, still allow it work with <ChartExpandButton>.

PreviewMap

Miscellaneous

Tests

Analytics

Browser Testing

  • Make it work on IE.
  • Specifically make Object.assign and Map work (or replace them).

UX

General

New issues

  • Clicking on the chart panel doesn't bring it in front of the feature info panel any more (moved to Clicking on the chart panel should bring it in front of the feature info panel #1691).
  • The map no longer resizes when opening/closing the chart panel.
  • If you "add data” when the chart panel is up, the add-data panel is half off the top of a small screen.
  • Remove mention of "Promise" from SearchBox.jsx (eslint error)
  • Remove mention of "confirm" from StandardUserInterface.jsx (eslint error)
  • When you drag a file onto the map, it only half slides the drag-n-drop screen onto the screen.
@kring
Copy link
Member

kring commented May 2, 2016

Preview map stops updating sometimes, not sure what causes this to happen.

Has anyone seen this since I refactored the preview? I don't think I have.

@kring
Copy link
Member

kring commented May 11, 2016

I don't see confirm in StandardUserInterface.jsx anymore, so I'm marking that one done.

@RacingTadpole
Copy link
Contributor Author

Closing in favour of individual issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants