Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in evaluation #715

Closed
Carbecq opened this issue Aug 29, 2024 · 2 comments · Fixed by #716
Closed

Bug in evaluation #715

Carbecq opened this issue Aug 29, 2024 · 2 comments · Fixed by #716

Comments

@Carbecq
Copy link

Carbecq commented Aug 29, 2024

In file evaluate.c, line 293, You use FILE_A... instead of FileABB...
@TerjeKir TerjeKir mentioned this issue Aug 29, 2024
Merged
TerjeKir added a commit that referenced this issue Aug 29, 2024
@TerjeKir
Remove bugged code that has no effect on the result (#716)
16e859e 
Fixes #715 

No functional change

Bench: 23621947
@TerjeKir
Copy link
Owner

Thanks for pointing this out! I've removed the bugged code as it had no effect on the end result, and will probably test adding back the corrected code to see if it's worth having there at all.

@TerjeKir
Copy link
Owner

Fixing this gained elo, thanks again for pointing it out :)

@TerjeKir TerjeKir mentioned this issue Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove bugged code that has no effect on the result TerjeKir/weiss
2 participants
@TerjeKir @Carbecq