fix: fix and re-enable some pathfinding tests #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- before the final expectedSize was the top and right-most path step's number increased by one
jdrueckert
added
Type: Bug
jdrueckert
changed the title
skaldarnar
changed the title
skaldarnar
approved these changes
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to MovingBlocks/Terasology#4981
This PR re-enables and fixes the
upAndDownAgainanddownAndUpAgaintest cases.It also provides more detail on why the
succeedAscendLate*test cases are sporadically failing and what the prerequisite to re-enabling them is. More details and explanatory screenshots of the underlying issue are provided in #30