Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add debug logs for movement plugins #94

Merged
merged 1 commit into from
Feb 19, 2022
Merged

chore: add debug logs for movement plugins #94

merged 1 commit into from
Feb 19, 2022

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Feb 19, 2022 •
edited
Loading

@jdrueckert jdrueckert added Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes labels Feb 19, 2022
@jdrueckert jdrueckert self-assigned this Feb 19, 2022
@jdrueckert
Copy link
Member Author

The changes of this PR should not result in any new test failures.
I created #95 to run the tests without any changes to see if there's currently any existing test failures that result from any changes outside of this module since develop was last built.

@jdrueckert
Copy link
Member Author

jdrueckert commented Feb 19, 2022 •
edited
Loading

The reference PR shows, that the "[walking, leaping]: jump over" test already fails before this PR.
It needs to be fixed in a follow-up outside of this PR.

@jdrueckert jdrueckert merged commit 0927200 into develop Feb 19, 2022
@jdrueckert jdrueckert deleted the chore/add-movement-plugin-debug-logs branch February 19, 2022 14:44
@skaldarnar skaldarnar mentioned this pull request Mar 13, 2022
Merged
skaldarnar added a commit that referenced this pull request Mar 13, 2022
@skaldarnar
fix: FlexiblePathfinding migration follow-ups (#92)
e14e58d 
- style: format `.behavior` files
- chore: add TODO ideas and questions in several places
- chore: add some debug logging
- feature/fix: small adjustments to Behaviors logic

Follow-up PR to #89.

Related PRs (extracted from this): #94, #96, #97, #99.

Contributes to MovingBlocks/Terasology#4981.

Depends on Terasology/FlexiblePathfinding#26 and Terasology/FlexiblePathfinding#27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaldarnar skaldarnar skaldarnar approved these changes

Assignees

@jdrueckert jdrueckert

Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrueckert @skaldarnar