Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(knapsack): docs for full screen dialog and focused page #2275

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

bsahitya
Copy link
Collaborator

@bsahitya bsahitya commented Nov 6, 2024

Description

  • Knapsack documentation for full screen dialog and focused page.
  • Fix for styling issue in full screen dialog which causes the dialog to flash.

What's included?

  • Fix flashing issue in full screen dialog component
  • Knapsack docs for full screen dialog and focused page

Test Steps

  • nx run knapsack:serve
  • Navigate to Components -> Full-screen dialog or Focused page
  • Verify the docs

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

focused-page-docs

Full-screen dialog close transition
full-screen-fix

owilliams320
owilliams320 previously approved these changes Nov 13, 2024
@bsahitya bsahitya merged commit 913f152 into main Nov 13, 2024
7 checks passed
@bsahitya bsahitya deleted the docs/knapsack-fullscreen-dialog branch November 13, 2024 17:30
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 8.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants