Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): full screen dialog and focused page web components #2264

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

bsahitya
Copy link
Collaborator

@bsahitya bsahitya commented Oct 30, 2024

Description

  • Add the below web components:
    • Full-screen dialog (cv-full-screen-dialog). It uses the cv-dialog component internally.
    • Focused page (cv-focused-page)

What's included?

  • Focused page component with a default slot for content and a help slot for help content.
    • helpOpen: Toggles the help section open/close
    • helpResizable: Whether the help section is resizable
    • hideTopBorder: Whether the top border should be hidden
  • Fullscreen dialog component with a default slot for content and a help slot for help content.
  • Includes the below properties in addition to the properties of focused page. It extends the focused page and cv-dialog components:
    • open: Toggles the component open/close
    • escapeKeyAction: Action to be taken when escape is pressed ('close` is the default action)

Test Steps

  • npm run storybook
  • Navigate to the Fullscreen dialog and Focused page stories
  • Play around with the properties

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

focused-page

Copy link
Collaborator

@adamnel adamnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the view is more narrow, and I open the help over the content, closing the help doesn't appear to clear the toggled state of the help icon. Seeing this on both new components:

help-toggle-state

@bsahitya bsahitya requested a review from adamnel November 4, 2024 16:27
@bsahitya bsahitya merged commit fcf9715 into main Nov 4, 2024
7 checks passed
@bsahitya bsahitya deleted the feat/full-screen-dialog branch November 4, 2024 19:31
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 8.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants