fix(angular): fixing dynamic menu open in new tab (#2380)

* fix(angular): fixing dynamic menu open in new tab * style(angular): adjust spacing in dynamic menu link component
Teradata · Feb 4, 2025 · a22cd00 · a22cd00
1 parent eb44c9d
commit a22cd00
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/libs/angular/dynamic-menu/src/dynamic-menu-item/dynamic-menu-item.component.html b/libs/angular/dynamic-menu/src/dynamic-menu-item/dynamic-menu-item.component.html
@@ -25,12 +25,10 @@
         <div class="group-label tc-td-secondary text-sm">{{ item.text }}</div>
       </ng-container>
       <ng-container *ngIf="item.link || item.action">
-        <div mat-menu-item class="pad-none">
-          <td-dynamic-menu-link
-            [item]="item"
-            (itemClicked)="emitClicked($event)"
-          ></td-dynamic-menu-link>
-        </div>
+        <td-dynamic-menu-link
+          [item]="item"
+          (itemClicked)="emitClicked($event)"
+        ></td-dynamic-menu-link>
       </ng-container>
     </ng-container>
   </ng-template>

diff --git a/...lar/dynamic-menu/src/dynamic-menu-item/dynamic-menu-link/dynamic-menu-link.component.html b/...lar/dynamic-menu/src/dynamic-menu-item/dynamic-menu-link/dynamic-menu-link.component.html
@@ -15,8 +15,10 @@
   <mat-icon *ngIf="item.icon" [class]="item.iconClasses">{{
     item.icon
   }}</mat-icon>
-  <span>{{ item.text }}</span>
-  <mat-icon *ngIf="item.newTab" class="new-tab-icon">launch</mat-icon>
+  <span class="item-link-text">
+    {{ item.text }}
+    <mat-icon *ngIf="item.newTab" class="new-tab-icon">launch</mat-icon>
+  </span>
 </a>
 <button
   *ngIf="item.action"

diff --git a/...lar/dynamic-menu/src/dynamic-menu-item/dynamic-menu-link/dynamic-menu-link.component.scss b/...lar/dynamic-menu/src/dynamic-menu-item/dynamic-menu-link/dynamic-menu-link.component.scss
@@ -10,4 +10,9 @@
   .new-tab-icon {
     margin: 0 0 0 16px;
   }
+
+  .item-link-text {
+    display: flex;
+    align-items: center;
+  }
 }