fix(full-screen-dialog): remove help close button

Teradata · Nov 4, 2024 · 5a32bcd · 5a32bcd
1 parent c9ee07b
commit 5a32bcd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 23 deletions.
diff --git a/libs/components/src/focused-page/focused-page.stories.js b/libs/components/src/focused-page/focused-page.stories.js
@@ -24,14 +24,7 @@ const Template = ({ helpOpen, helpResizable, hideTopBorder }) => {
   document.addEventListener(
     'DOMContentLoaded',
     () => {
-      const helpCloseButton = document.body.querySelector('.help-close');
       const helpToggleButton = document.body.querySelector('.help-toggle');
-      helpCloseButton.addEventListener('click', () => {
-        const dialog = document.body.querySelector('#focused-page');
-        dialog.helpOpen = false;
-        helpToggleButton.on = false;
-        helpToggleButton.toggledOn = false;
-      });
 
       helpToggleButton.addEventListener('click', () => {
         const dialog = document.body.querySelector('#focused-page');
@@ -50,9 +43,7 @@ const Template = ({ helpOpen, helpResizable, hideTopBorder }) => {
     
     <cv-toolbar>
         <span slot="title">
-            <cv-typography scale="headline4">
-                Connect data source
-            </cv-typography>
+            Connect data source
         </span>
         <cv-icon-button-toggle onIcon="help" offIcon="help" class="help-toggle"
             slot="actionItems"></cv-icon-button-toggle>
@@ -129,7 +120,6 @@ const Template = ({ helpOpen, helpResizable, hideTopBorder }) => {
         <cv-toolbar sticky>
             <span slot="title" style="padding-left: 4px;">Help</span>
             <cv-icon-button slot="actionItems" icon="undock" covalent-icons></cv-icon-button>
-            <cv-icon-button slot="actionItems" icon="close" class="help-close"></cv-icon-button>
         </cv-toolbar>
         <div style="padding: 16px">
             <cv-typography scale="headline5">

diff --git a/libs/components/src/full-screen-dialog/full-screen-dialog.stories.js b/libs/components/src/full-screen-dialog/full-screen-dialog.stories.js
@@ -24,7 +24,6 @@ const Template = ({ helpOpen, helpResizable, open, escapeKeyAction }) => {
     'DOMContentLoaded',
     () => {
       const button = document.body.querySelector('#dialog-button');
-      const helpCloseButton = document.body.querySelector('.help-close');
       const helpToggleButton = document.body.querySelector('.help-toggle');
       const fullscreenCloseButton = document.body.querySelector(
         '.full-screen-dialog-close'
@@ -34,17 +33,11 @@ const Template = ({ helpOpen, helpResizable, open, escapeKeyAction }) => {
         dialog.open = true;
       });
 
-      helpCloseButton.addEventListener('click', () => {
-        const dialog = document.body.querySelector('#dialog1');
-        dialog.helpOpen = false;
-        helpToggleButton.on = false;
-        helpToggleButton.toggledOn = false;
-      });
-
       helpToggleButton.addEventListener('click', () => {
         const dialog = document.body.querySelector('#dialog1');
         dialog.helpOpen = !dialog.helpOpen;
       });
+
       fullscreenCloseButton.addEventListener('click', () => {
         const dialog = document.body.querySelector('#dialog1');
         dialog.open = false;
@@ -65,9 +58,7 @@ const Template = ({ helpOpen, helpResizable, open, escapeKeyAction }) => {
     
     <cv-toolbar>
         <span slot="title">
-            <cv-typography scale="headline4">
-                Connect data source
-            </cv-typography>
+          Connect data source
         </span>
         <cv-icon-button-toggle onIcon="help" offIcon="help" class="help-toggle"
             slot="actionItems"></cv-icon-button-toggle>
@@ -146,7 +137,6 @@ const Template = ({ helpOpen, helpResizable, open, escapeKeyAction }) => {
         <cv-toolbar sticky>
             <span slot="title" style="padding-left: 4px;">Help</span>
             <cv-icon-button slot="actionItems" icon="undock" covalent-icons></cv-icon-button>
-            <cv-icon-button slot="actionItems" icon="close" class="help-close"></cv-icon-button>
         </cv-toolbar>
         <div style="padding: 16px">
             <cv-typography scale="headline5">