-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove placebo (vulkan not support in wsl2 yet #46
Conversation
Reviewer's Guide by SourceryThis pull request removes the installation of the placebo library and its associated VapourSynth plugin from the Dockerfiles. This is because Vulkan, which placebo relies on, is not yet supported in WSL2. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Tohrusky - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hardcoded root password found. (link)
Overall Comments:
- Please improve the commit message and PR description to clearly explain why Vulkan/libplacebo support is being removed and any implications for users.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
RUN sed -i 's/#Port 22/Port 22/' /etc/ssh/sshd_config | ||
RUN sed 's@session\s*required\s*pam_loginuid.so@session optional pam_loginuid.so@g' -i /etc/pam.d/sshd | ||
RUN apt install openssh-server -y && \ | ||
echo 'root:123456' | chpasswd && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Hardcoded root password found.
The root password 123456
is hardcoded in the Dockerfile. This is a significant security risk and should be removed. Consider using a more secure mechanism for setting the root password, such as using environment variables or generating a random password during container startup.
vulkan暂时不好整
Summary by Sourcery
Remove libplacebo and update mbfunc.
Build:
Documentation: