Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove placebo (vulkan not support in wsl2 yet #46

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

Tohrusky
Copy link
Member

@Tohrusky Tohrusky commented Jan 30, 2025

vulkan暂时不好整

Summary by Sourcery

Remove libplacebo and update mbfunc.

Build:

  • Remove libplacebo from vs-pytorch-rocm.dockerfile and vs-pytorch.dockerfile.
  • Update mbfunc from 0.0.3 to 0.1.0 in vs-pytorch-rocm.dockerfile and vs-pytorch.dockerfile.
  • Chain installation commands for ssh in vs-playground.dockerfile.

Documentation:

  • Remove libplacebo.so from the list of VapourSynth plugins in README.md.

Copy link

sourcery-ai bot commented Jan 30, 2025

Reviewer's Guide by Sourcery

This pull request removes the installation of the placebo library and its associated VapourSynth plugin from the Dockerfiles. This is because Vulkan, which placebo relies on, is not yet supported in WSL2.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed placebo and vs-placebo installation.
  • Removed the git clone command for libplacebo.
  • Removed the meson build and install commands for libplacebo.
  • Removed the git clone command for vs-placebo.
  • Removed the meson build and install commands for vs-placebo.
  • Removed the symbolic link creation for libplacebo.so.
vs-pytorch-rocm.dockerfile
vs-pytorch.dockerfile
Updated mbfunc version.
  • Updated mbfunc version from 0.0.3 to 0.1.0.
vs-pytorch-rocm.dockerfile
vs-pytorch.dockerfile
Modified ssh configuration in vs-playground.dockerfile.
  • Combined multiple RUN commands into a single one using &&.
vs-playground.dockerfile
Removed libplacebo and libvs_placebo from README.md.
  • Removed libplacebo.so from the list of libraries.
  • Removed libvs_placebo.so from the list of libraries.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Tohrusky - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Hardcoded root password found. (link)

Overall Comments:

  • Please improve the commit message and PR description to clearly explain why Vulkan/libplacebo support is being removed and any implications for users.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🔴 Security: 1 blocking issue
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

RUN sed -i 's/#Port 22/Port 22/' /etc/ssh/sshd_config
RUN sed 's@session\s*required\s*pam_loginuid.so@session optional pam_loginuid.so@g' -i /etc/pam.d/sshd
RUN apt install openssh-server -y && \
echo 'root:123456' | chpasswd && \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 issue (security): Hardcoded root password found.

The root password 123456 is hardcoded in the Dockerfile. This is a significant security risk and should be removed. Consider using a more secure mechanism for setting the root password, such as using environment variables or generating a random password during container startup.

@Tohrusky Tohrusky merged commit 2765de6 into TensoRaws:main Jan 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant