Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support no-cut mode #88

Merged
merged 4 commits into from
Dec 4, 2024
Merged

feat: support no-cut mode #88

merged 4 commits into from
Dec 4, 2024

Conversation

chenpt0809
Copy link
Contributor

@chenpt0809 chenpt0809 commented Dec 2, 2024

Summary by Sourcery

Add support for a 'no-cut' mode feature, allowing users to toggle video slicing. Update dependencies to their latest versions for improved compatibility and security. Enhance README.md by consolidating badge links.

New Features:

  • Introduce a 'no-cut' mode feature in the application, allowing users to toggle video slicing through a new UI switch.

Enhancements:

  • Update various dependencies in the pnpm-lock.yaml file to their latest versions, ensuring compatibility and security improvements.

Documentation:

  • Update README.md to consolidate badge links into a single line for better readability.

Copy link

sourcery-ai bot commented Dec 2, 2024

Reviewer's Guide by Sourcery

This pull request adds a 'no-cut' mode feature by introducing a toggle switch in the UI that allows users to control whether videos should be sliced into clips. The implementation includes UI changes to the Settings view, updates to the store to manage the slice mode state, and modifications to the task submission logic to include the slicing preference.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a slice mode toggle switch to the Settings view
  • Added a new NCard component with a switch control for toggling slice mode
  • Imported sliceMode from the settings store
src/views/Setting.vue
Added slice mode state management in the settings store
  • Added sliceMode ref with default value true
  • Added sliceMode to the store's exposed state
  • Added sliceMode to the list of persisted state properties
src/store/setting.ts
Updated task submission to include slice mode preference
  • Imported sliceMode from settings store
  • Added slice parameter to task submission API call
src/views/Start.vue
Updated package dependencies and configuration
  • Updated various package versions in package.json
  • Updated package lock file with new dependency versions
  • Added NSwitch component to the auto-generated components.d.ts
package.json
pnpm-lock.yaml
components.d.ts
Reformatted README badges layout
  • Consolidated CI badges into a single line
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chenpt0809 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using consistent terminology between PR title ('no-cut mode') and UI ('slicing') to avoid confusion
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Tohrusky
Copy link
Member

Tohrusky commented Dec 4, 2024

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chenpt0809 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Tohrusky Tohrusky changed the title feat: support no-cut mode (#40) feat: support no-cut mode Dec 4, 2024
@Tohrusky Tohrusky merged commit 1a09cf9 into TensoRaws:main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants