feature: 忘记密码支持手机号验证，进行密码重置 # issue631 #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Canway-shiisa please review the code |
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
|
@Canway-shiisa @wklken @nannan00 please review |
Merged
|
先解下冲突 |
wklken
reviewed
Dec 15, 2022
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
|
handler要么去掉继承 => 尽量简化下, 本身逻辑并不复杂, 没必要继承+一大堆方法 |
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
wklken
reviewed
Dec 16, 2022
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
neronkl
requested review from
Canway-shiisa
and removed request for
nannan00
nannan00
reviewed
Dec 16, 2022
wklken
reviewed
Dec 16, 2022
wklken
reviewed
Dec 16, 2022
wklken
reviewed
Dec 16, 2022
wklken
reviewed
Dec 16, 2022
src/api/bkuser_core/api/web/password/verification_code_handler.py
Outdated
Show resolved
Hide resolved
wklken
reviewed
Dec 16, 2022
wklken
reviewed
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.