Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] reshape shape expression #5918

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

nihui
Copy link
Member

@nihui nihui commented Feb 21, 2025

  • test eval expression
  • test reshape shape expression
  • simplemath exclusion
  • simplestl stack
  • pnnx expression to ncnn (resolve ndim for reshape, reference tag and op substitution)
  • pnnx ncnn dynamic reshape test
  • doc

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 70.15945% with 131 lines in your changes missing coverage. Please review.

Project coverage is 94.95%. Comparing base (1e3fcb9) to head (b66b1f5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/expression.cpp 60.86% 99 Missing ⚠️
src/layer/x86/reshape_x86.cpp 75.00% 30 Missing ⚠️
src/layer/reshape.cpp 98.14% 1 Missing ⚠️
src/paramdict.cpp 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5918       +/-   ##
===========================================
- Coverage   95.40%   94.95%    -0.45%     
===========================================
  Files         818      467      -351     
  Lines      268459   112538   -155921     
===========================================
- Hits       256111   106866   -149245     
+ Misses      12348     5672     -6676     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the x86 label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants