Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] #623

Closed
3 tasks
123GaoLin opened this issue Oct 17, 2023 · 1 comment
Closed
3 tasks

[Bug report] #623

123GaoLin opened this issue Oct 17, 2023 · 1 comment
Labels
🐞bug Something isn't working

Comments

@123GaoLin
Copy link

Describe the bug

enablePreviewerBubble 设置为 false 时

  • 预览模式下的代码块会有编辑、复制按钮。
  • makeHtml 读取到的代码块，会有下拉选择、编辑、复制按钮。

Reproduction

No response

System Info

No response

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Help us

None
@sunsonliu sunsonliu added the 🐞bug Something isn't working label Oct 19, 2023
@sunsonliu sunsonliu mentioned this issue Nov 16, 2023
Closed
3 tasks
@sunsonliu
Copy link
Collaborator

已经提交到了dev分支，新的逻辑下makeHtml不会再输出下拉、编辑等无用的元素了。
同时在配置里增加了“是否支持预览区切换语言”的配置，见下图
image

jiawei686 added a commit that referenced this issue Nov 20, 2023
@jiawei686
Merge branch 'dev'
7d555a1 
* dev:
  chore(release): v0.8.28
  chore(*): remove useless style import & add build:styles command (#646)
  Update Toolbar.js 兼容手机普通点击事件,替换为pointerup
  Update README.md
  Merge branch 'dev' into main
  chore(*): update issue templates (#645)
  fix: #621 closed 修复纯预览模式切换成编辑模式时工具栏不显示的问题
  lint
  fix: #623 重构代码块预览区编辑功能，同时修复预览区工具栏滚动时超出界面的问题，增加是否允许切换代码块语言的功能
  docs: add API  instructions (#634)

# Conflicts:
#	dist/cherry-markdown.js
#	dist/fonts/ch-icon.eot
#	dist/fonts/ch-icon.ttf
#	dist/fonts/ch-icon.woff
#	dist/fonts/ch-icon.woff2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunsonliu @123GaoLin