Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ios): Generating logs by default, regardless of Debug or not #3614

Merged
merged 2 commits into from
Nov 21, 2023
Merged

refactor(ios): Generating logs by default, regardless of Debug or not #3614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2ae6d9
refactor(ios): Generating logs by default, regardless of Debug or not
wwwcg Nov 15, 2023
8b16e68
Merge branch 'main' into hippy3_fix_13
open-hippy Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions modules/ios/base/HippyLog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,6 @@
#import <Foundation/Foundation.h>
#import "HippyDefines.h"

#ifndef HIPPY_LOG_ENABLED
#ifdef DEBUG
#define HIPPY_LOG_ENABLED 1
#else
#define HIPPY_LOG_ENABLED 0
#endif //#ifdef DEBUG
#endif //#ifndef HIPPY_LOG_ENABLED

/**
* Thresholds for logs to display a redbox. You can override these values when debugging
* in order to tweak the default logging behavior.
Expand Down Expand Up @@ -125,13 +117,7 @@ HIPPY_EXTERN void HippyPerformBlockWithLogPrefix(void (^block)(void), NSString *
/**
* Private logging function - ignore this.
*/
#if HIPPY_LOG_ENABLED
#define _HippyLog(lvl, ...) HippyLogNativeInternal(lvl, __FILE__, __LINE__, __VA_ARGS__);
#else
#define _HippyLog(lvl, ...) \
do { \
} while (0)
#endif

HIPPY_EXTERN void HippyLogNativeInternal(HippyLogLevel, const char *, int, NSString *, ...) NS_FORMAT_FUNCTION(4, 5);

Expand Down