Fixes a typo in Xcode #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, thank you for your patch. Please take care of the commit message, Hippy is following the Conventional Commits guideline. The correct commit message should be BTW: Could you check more typo mistakes and make a submission? |
|
Interesting. I've renamed the commit message to conform to the guideline. I did search for any other cases of Xcode spelling but looks like everywhere else you got it right. Thanks! |
tempelmann
approved these changes
Dec 25, 2019
|
Sorry, it's fixed in #28, I have to close the PR. |
|
Well, that‘s disappointing. |
Closed
zealotchen0
pushed a commit
to zealotchen0/Hippy
that referenced
this pull request
Mar 11, 2024
* complete webview Signed-off-by: shitijun <[email protected]> * add textinput Signed-off-by: shitijun <[email protected]> * modify viewpager and textinput Signed-off-by: shitijun <[email protected]> * fix cannot scroll Signed-off-by: shitijun <[email protected]> * modify ViewPager/RefreshWrapper/ScrollView/WaterFlow Signed-off-by: shitijun <[email protected]> * modify Modal/PullFooter/PullHeader Signed-off-by: shitijun <[email protected]> --------- Signed-off-by: shitijun <[email protected]>
zealotchen0
pushed a commit
to zealotchen0/Hippy
that referenced
this pull request
May 29, 2024
* complete webview Signed-off-by: shitijun <[email protected]> * add textinput Signed-off-by: shitijun <[email protected]> * modify viewpager and textinput Signed-off-by: shitijun <[email protected]> * fix cannot scroll Signed-off-by: shitijun <[email protected]> * modify ViewPager/RefreshWrapper/ScrollView/WaterFlow Signed-off-by: shitijun <[email protected]> * modify Modal/PullFooter/PullHeader Signed-off-by: shitijun <[email protected]> --------- Signed-off-by: shitijun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small typo in Xcode. CLA signed.