Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #15

Closed
wants to merge 1 commit into from
Closed

chore: update dependencies #15

wants to merge 1 commit into from

Conversation

hugo19941994
Copy link
Contributor

I started to receive a notification from Github about a vulnerability in eslint, so I thought I would take some time and do some maintenance:

The following dependencies were not fully upgraded (although no vulnerabilities were found in these versions):

  • eslint 7 requires node 10, so eslint 6.8 is used
  • jwa 2 breaks compatibility (ciphers are now case sensitive). version 1.4.1 used instead (^1.0.0 in package.json)
  • therror doesn't have a register function in versions >0.2. I think it might be better to update it in a separate PR if necessary.

Squashed commit of the following:

commit a61cace46f4f745283177a6ca4551e6237aa4d8a
Author: Hugo Ferrando Seage <[email protected]>
Date:   Wed May 13 15:33:19 2020 +0200

    Downgrade eslint to version 6.8.0

    Version 7 dropped support for node 8

commit f08aa1e125738fe00183306f925d4e2ecf9e5704
Author: Hugo Ferrando Seage <[email protected]>
Date:   Wed May 13 14:52:18 2020 +0200

    FIX unit tests

    - Made environment.js work with the newer mocha version
    - Remove all Buffer constructors
    - Change test order to fix broken tests in node < 10.7
      - nodejs/node#21288
    - Changed minimum node version to 8, due to the updated dependencies

commit ce1f40d4e5ae79f4bcf6a3cca0f914ef51effd3b
Author: Hugo Ferrando Seage <[email protected]>
Date:   Wed May 13 14:52:04 2020 +0200

    Relint jwt-utils.js with newer eslint rules

commit 59940f5552dbfb8353e71250b1a0d3038913a17e
Author: Hugo Ferrando Seage <[email protected]>
Date:   Wed May 13 14:50:51 2020 +0200

    Replace new Buffer with Buffer.from and Buffer.alloc

    The Buffer constructor was deprecated: https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/

commit b46245788a6235b0490f9902e9218945cb6d585c
Author: Hugo Ferrando Seage <[email protected]>
Date:   Wed May 13 14:48:56 2020 +0200

    Remove travis and coveralls badges

    Also removed the .travis file and npm script. Neither service is
    executing their pipelines for this repo anymore

commit 23f537ad6fdc4b8924add6feb16628512529a47a
Author: Hugo Ferrando Seage <[email protected]>
Date:   Wed May 13 14:48:42 2020 +0200

    Integrate jscsrc rules into eslintrc

commit c0e23b53a27d82d14430d05b63426dcae868cfd9
Author: Hugo Ferrando Seage <[email protected]>
Date:   Wed May 13 14:44:52 2020 +0200

    CHORE update dependencies

    - coveralls removed as the pipeline is not executed anymore
    - jscs removed as it was deprecated
    - added eslint-google dependency to replace jscs with eslint
    - jwa NOT updated as it would break compatibility
    - therror NOT updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants