Skip to content
This repository has been archived by the owner on Sep 14, 2024. It is now read-only.

add some basic ci configuration #8

Merged
merged 2 commits into from
Jul 29, 2020
Merged

add some basic ci configuration #8

merged 2 commits into from
Jul 29, 2020

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented Jul 25, 2020

untested. Let's see if it builds.

@Mic92 Mic92 marked this pull request as ready for review July 25, 2020 22:41
@Mic92 Mic92 force-pushed the ci branch 2 times, most recently from 8ddc8f5 to 964a9b3 Compare July 25, 2020 22:46
This at least checks if we did not accidently broke the build.
The next step is to upload actual apk's for testing
@Teifun2
Copy link
Owner

Teifun2 commented Jul 25, 2020

Thanks for starting this! Should this be merged now to check that the basic debug build action works? or do you want to add the uploading of apks before that?

@Mic92
Copy link
Contributor Author

Mic92 commented Jul 27, 2020

You can merge this as it is. It already provides assurance that PRs don't break the build. Uploading APKs needs be done in a seperate github action, which is only triggered on releases so there is a release tag where files can be uploaded to.

@Mic92
Copy link
Contributor Author

Mic92 commented Jul 27, 2020

@Mic92 Mic92 mentioned this pull request Jul 27, 2020
@Teifun2 Teifun2 merged commit f1e91a1 into Teifun2:master Jul 29, 2020
@Teifun2
Copy link
Owner

Teifun2 commented Jul 29, 2020

Thanks for your help!

@Mic92 Mic92 deleted the ci branch July 29, 2020 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants