Allow extra configuration file #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to override some configuration settings, we can now specify an additional configuration location using the Java system properties ``ice.config.location`` which points to another configuration file location. Otherwise, the only way to set custom configuration parameters is by overriding this while Config.groovy file.
NitriKx
previously approved these changes
Aug 1, 2017
|
Thanks for contributing! Can you update the README with a description of the new parameter? |
|
@NitriKx That should be better now :) |
NitriKx
reviewed
Aug 1, 2017
README.md
Outdated
|
|
||
| If you need to setup custom Grails settings, you can specify an additional configuration file to be loaded by Grails by setting the ``ice.config.location`` system property to the location of that file. | ||
|
|
||
| See http://docs.grails.org/2.3.7/guide/single.html#configExternalized for more information. |
There was a problem hiding this comment.
Should be replaced with http://docs.grails.org/2.4.4/guide/single.html#configExternalized (as we use 2.4.4 in Ice)
There was a problem hiding this comment.
Right, sorry I missed that!
NitriKx
added a commit
that referenced
this pull request
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to override some configuration settings, we can now specify an
additional configuration location using the Java system properties
ice.config.locationwhich points to another configuration filelocation.
Otherwise, the only way to set custom configuration parameters is by
overriding this while Config.groovy file.