-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Allow drop folder(s) #2
Conversation
Wow, that was quick! Thank you, @nithins 🎉 |
Thanks for the review @leMaik . I've incorporated all the changes. The only change that feels iffy is on how to check if webkitGetAsEntry API is supported. Currently, the items[0] is being checked . There could be a better way. Please let me know if you can think of anything. |
@nithins Thank you! 👏 You could detect support outside of the handler like this:
Edit: Turns out it's pretty widely supported, I didn't expect that 😮 |
Hi @leMaik . I have completed and checked in the changes on the fork. I'm not sure of how to merge pull requests. Please let me know if there is anything I need to do. Also, I could squash the changes to maintain a single commit before you merge the pull request. |
@nithins Sorry, this went off my radar 😬 I'm publishing a new release right now, thanks again for your work! 🎉 |
@leMaik. Thanks for letting me know. Happy to contribute.
…On Mon, 19 Oct 2020 at 20:01, Maik Marschner ***@***.***> wrote:
@nithins <https://github.com/nithins> Sorry, this went off my radar 😬
I'm publishing a new release right now, thanks again for your work! 🎉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABQ2SSQWR7VX4A3UKAJTJTSLREVLANCNFSM4RV2CRUQ>
.
|
This feature allows the DropAreaBase to accept folders as well. Folder(s) will be recursively scanned and the files within will be collected into a flat array. The file array is passed on to
onSelectFiles
Tested on
Resolves #1